Update default bundler and ruby versions #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 8.0.1 needs Ruby 3.2+ and unfortunately they decided to stop shipping with a Ruby version in the Gemfile. I don't yet have `.ruby-version` support, but this will at least allow a `rails new` app to work on Heroku with the default versions.
schneems
force-pushed
the
schneems/update-default
branch
from
64dd3e1 to
9a894bf
Compare
We're no longer modifying metadata, we can safely disable this test (which now fails because the defaults are changing between the versions).
Older versions of JRuby do not play well with newer versions of bundler:
```
- Running `BUNDLE_BIN="/layers/heroku_ruby/gems/bin" BUNDLE_CLEAN="1" BUNDLE_DEPLOYMENT="1" BUNDLE_GEMFILE="/workspace/Gemfile" BUNDLE_PATH="/layers/heroku_ruby/gems" BUNDLE_WITHOUT="development:test" bundle install`
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
NoMethodError: undefined method `request' for nil:NilClass
Did you mean? require
conflicting_dependencies at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems/resolver/conflict.rb:47
conflicting_dependencies at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems/exceptions.rb:32
initialize at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems/exceptions.rb:26
new at org/jruby/RubyClass.java:909
exception at org/jruby/RubyException.java:129
resolve at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems/resolver.rb:193
resolve at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems/request_set.rb:411
resolve_current at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems/request_set.rb:423
finish_resolve at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems.rb:240
activate_bin_path at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems.rb:300
synchronize at org/jruby/ext/thread/Mutex.java:171
activate_bin_path at /layers/heroku_ruby/ruby/lib/ruby/stdlib/rubygems.rb:298
<main> at /layers/heroku_ruby/bundler/bin/bundle:23
```
edmorley
approved these changes
Dec 16, 2024
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 17, 2024
## heroku/ruby ### Changed - Default Ruby version is now 3.2.6 ([#374](heroku/buildpacks-ruby#374)) - Default Bundler version is now 2.5.6 ([#374](heroku/buildpacks-ruby#374))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 8.0.1 needs Ruby 3.2+ and unfortunately they decided to stop shipping with a Ruby version in the Gemfile. I don't yet have
.ruby-versionsupport, but this will at least allow arails newapp to work on Heroku with the default versions.