Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue replacing Layer trait with Struct API and using bullet stream #334

Merged
merged 39 commits into from
Oct 15, 2024
Merged

Continue replacing Layer trait with Struct API and using bullet stream #334

merged 39 commits into from
Oct 15, 2024

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Oct 9, 2024

Commits are small and descriptive.

schneems added 30 commits October 8, 2024 10:56
@schneems
Remove section logger from bundle list
5d45679
@schneems
Change top level bullet to a noun
7a10615
@schneems
Refactor command to functional style
6ebbf05
@schneems
Move logic to function
7b3b12c
@schneems
Replace section logger with bullet stream
95c5e0f
@schneems
Replace logging with bullet stream
ee7a3e0
@schneems
Remove SectionLogger guard
caced42
@schneems
Remove SectionLogger guard
04c887a
@schneems
Replace section logger with bullet stream
76af8fc
@schneems
Wire bullet stream input and output
960fa98
@schneems
Replace section log with bullet stream
0c03dc5
@schneems
Replace section log with bullet stream
5ffe2d5
@schneems
Replace section log with bullet stream
49981b4
@schneems
Pluralize word
c40b5d1
@schneems
Replace section log with bullet stream
f6127e7
@schneems
Move associated function to function
8fa7ee1
@schneems
Wire up bullet stream
9859169
@schneems
Use bullet stream for rake -p
876b8f4
@schneems
Wire bullet stream
89c7cc7
@schneems
Replace section logger with bullet stream
e429456
@schneems
Replace section logger with bullet stream
27fc631
@schneems
Replace section logger with bullet stream
8ca4359
@schneems
Inline AppCacheCollection logic
4fd2888 
This is a pretty useless struct that hides the underlying logic I want to deprecate it.
@schneems
Remove output fmt module import
0f983c6
@schneems
Inline command call
5aad895
@schneems
Replace section log with bullet stream
8b1d3fa
@schneems
Use value directly instead of making a variable
3f1c7e0
@schneems
Inline command creation
f3613b1
@schneems
Use value directly
9e11414
@schneems
Remove log_* calls in favor of bullet stream
fd0b52d
@schneems schneems marked this pull request as ready for review October 9, 2024 00:45
@schneems schneems requested a review from a team as a code owner October 9, 2024 00:45
runesoerensen
runesoerensen requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@runesoerensen runesoerensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we perhaps add a changelog entry noting the commons/src/cache/app_cache_collection.rs deprecations?

buildpacks/ruby/src/steps/rake_assets_install.rs Outdated Show resolved Hide resolved
@schneems schneems enabled auto-merge (squash) October 15, 2024 17:38
@schneems @runesoerensen
Update commons/CHANGELOG.md
4f2c9ea 
Co-authored-by: Rune Soerensen <[email protected]>
@schneems schneems merged commit cc50d62 into main Oct 15, 2024
7 checks passed
@schneems schneems deleted the schneems/gem-list-refactor branch October 15, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runesoerensen runesoerensen runesoerensen approved these changes

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneems @runesoerensen