Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure process to complain about unset variable #307

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Configure process to complain about unset variable #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
967d405
configure process to complain about unset variable
lilacstella Jul 19, 2024
a2a5646
Update CHANGELOG.md
lilacstella Jul 19, 2024
2886d68
configure process to complain about unset variable
lilacstella Jul 19, 2024
b1bf6f4
Update CHANGELOG.md
lilacstella Jul 19, 2024
af05fc9
Merge branch 'lilacstella/hint-missing-param' of github.com:heroku/bu…
lilacstella Jul 31, 2024
55b6d00
Update grammar in changelog
lilacstella Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions buildpacks/ruby/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- The buildpack now warns the user when environmental variables used in running the default process are not defined. ([#307](https://github.com/heroku/buildpacks-ruby/pull/307))

## [3.0.0] - 2024-05-17

### Changed
Expand Down
4 changes: 2 additions & 2 deletions buildpacks/ruby/src/steps/get_default_process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ fn default_rack() -> Process {
"-c",
&[
"bundle exec rackup",
"--port \"$PORT\"",
"--port \"${PORT:?Error: PORT env var is not set!}\"",
"--host \"0.0.0.0\"",
]
.join(" "),
Expand All @@ -91,7 +91,7 @@ fn default_rails() -> Process {
"-c",
&[
"bin/rails server",
"--port \"$PORT\"",
"--port \"${PORT:?Error: PORT env var is not set!}\"",
"--environment \"$RAILS_ENV\"",
]
.join(" "),
Expand Down