Use pack build --force-color in CI instead of script TTY workaround
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Pack 0.33.0 (which this repo is using thanks to #462), there is a new `--force-color` argument that makes `pack build` output logs in colour even if a TTY wasn't detected (as is the case on GHA): https://github.com/buildpacks/pack/releases/tag/v0.33.0 This makes the `script -e -c` TTY workaround in CI unnecessary. I've also: - removed a redundant `cargo build` step (run does a build, and the Cargo compilation output can be suppressed using `--quiet`) - replaced a manual git clone with `actions/checkout`, since it handles things like retries, faster shallow clones etc. GUS-W-14968745.
Malax
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Pack 0.33.0 (which this repo is using thanks to #462), there is a new
--force-colorargument that makespack buildoutput logs in colour even if a TTY wasn't detected (as is the case on GHA):https://github.com/buildpacks/pack/releases/tag/v0.33.0
This makes the
script -e -cTTY workaround unnecessary. (It's also not needed for any direct Cargo usages, since they are covered by the existingCARGO_TERM_COLOR: always.)I've also:
cargo buildstep (run does a build, and the Cargo compilation output can be suppressed using--quiet)actions/checkout, since it handles things like retries, faster shallow clones etc.GUS-W-14968745.