Code

Update the logging interface#198

Code

Merged

schneems merged 80 commits intomainheroku/buildpacks-ruby:mainfrom schneems/logging-state-machine-continuedheroku/buildpacks-ruby:schneems/logging-state-machine-continuedCopy head branch name to clipboardOct 30, 2023

+3,373-1,520

Commits

Commits on Oct 30, 2023

• WIP

  

  Malax

  authored and

  schneems

  committed
  1024fa3

• Threaded printing with internal writer passing works

  Show description for 32b3bdb
  schneems

  committed
  32b3bdb

• WIP scoped thread experiment

  schneems

  committed
  4b3da91

• WIP non-scopped-background logger

  schneems

  committed
  93aad71

• Implement Stop timer on drop

  schneems

  committed
  b958e79

• WIP cannot get data back out

  schneems

  committed
  83f7373

• Introduce BuildLog

  Show description for 5128e1c
  schneems

  committed
  5128e1c

• Cleanup

  Show description for 8b6b0d6
  schneems

  committed
  8b6b0d6

• Test using memory instead of files

  Show description for 1cdce80
  schneems

  committed
  1cdce80

• Expose streaming io in BuildLog

  Show description for 700caa0
  schneems

  committed
  700caa0

• Fun run interfaces

  Show description for eaa6f60
  schneems

  committed
  eaa6f60

• Introduce CommandWithName trait

  Show description for 3d91951
  schneems

  committed
  3d91951

• Expose output interface

  schneems

  committed
  7fc8b08

• WIP layer logging

  Show description for 0d43b19
  schneems

  committed
  0d43b19

• Debuggable logger

  schneems

  committed
  bb8ffc0

• WIP Layer logging without lifetime

  schneems

  committed
  bec7d0a

• Layer logger cleaned up

  schneems

  committed
  4b1680b

• Bundle download layer moved to new output interface

  schneems

  committed
  4b90209

• Bundle install layer moved to new output interface

  schneems

  committed
  9db0281

• Gem list and default processesmoved to new output interface

  schneems

  committed
  02751a1

• Take tasks logging moved to new output interface

  schneems

  committed
  5e86112

• Delete old build logging module

  Show description for 4adc1dd
  schneems

  committed
  4adc1dd

• Match error text to prior work

  Show description for 0b050b2
  schneems

  committed
  0b050b2

• Address clippy complaints and move LayerLogger

  Show description for 46868c4
  schneems

  committed
  46868c4

• Preserve long command for debugging

  Show description for 1689a4b
  schneems

  committed
  1689a4b

• Add ls -la diagnostics to missing Gemfile.lock

  schneems

  committed
  663adc8

• Align multiline step and section contents

  Show description for d22ab4a
  schneems

  committed
  d22ab4a

• Fix outstanding error formatting TODOs

  schneems

  committed
  b7a1dcb

• Introduce living style guide

  Show description for bea1c25
  schneems

  committed
  bea1c25

• Handle control characters when indenting with a prefix

  schneems

  committed
  fd6add4

• Make SectionLogger.step chainable

  Show description for d2e0cea
  schneems

  committed
  d2e0cea

• Clippy

  schneems

  committed
  1cbba84

• Expose function only section logging interface

  Show description for a6ac403
  schneems

  committed
  a6ac403

• Remove LayerLogger in favor of section_log mod

  schneems

  committed
  c8b77b5

• Inject metadata for all layers

  Show description for b712ff6
  schneems

  committed
  b712ff6

• Print style guide on CI runs

  schneems

  committed
  a9a70af

• Clippy, CI, and CHANGELOG

  schneems

  committed
  4b6e8b0

• Clean up module visibility

  schneems

  committed
  3959c48

• Move panic into tested unit code path

  schneems

  committed
  cd34e52

• Introduce fat::HELP and fat::DEBUG_INFO constants

  Show description for b0a93be
  schneems

  committed
  b0a93be

• Add docs and rearrange code

  schneems

  committed
  d37e549

• Reduce timing effects from tests

  Show description for 061af1d
  schneems

  committed
  061af1d

• Clippy

  schneems

  committed
  154be44

• Docs

  schneems

  committed
  0dcab5a

• Remove panic when joining logger

  Show description for a156403
  schneems

  committed
  a156403

• Allow wildcard imports to bring in interface

  Show description for e3eb83b
  schneems

  committed
  e3eb83b

• Move output::log to output::build_log

  Show description for 8724e73
  schneems

  committed
  8724e73

• Test dropping StopJoinGuard stops background logging

  schneems

  committed
  7da4e7f

• Failing test for desired warning formatting

  Show description for 1562d21
  schneems

  committed
  1562d21

• Fix warning/important/error formatting using trait

  Show description for 4d15725
  schneems

  committed
  4d15725

• Refactor data inside of BuildLog

  Show description for b56b750
  schneems

  committed
  b56b750

• Add delayed warnings for buildpack authors

  schneems

  committed
  080aaf4

• Warn later with thread locals

  Show description for e1cc7cf
  schneems

  committed
  e1cc7cf

• Allow ReadYourWrite to be cloneable

  schneems

  committed
  5e6f977

• Refactor ReadYourWrite to return a Reader struct

  Show description for e7d203d
  schneems

  committed
  e7d203d

• Fix warn later extra whitespace

  Show description for 4e613e3
  schneems

  committed
  4e613e3

• Fix CI.yml format

  schneems

  committed
  8a9c5e5

• Fix CI section naming

  schneems

  committed
  f6c1cae

• Update rust cache

  schneems

  committed
  9726acf

• Failing warn_later test

  Show description for 98c410e
  schneems

  committed
  98c410e

• Fix function name

  schneems

  committed
  cd105e0

• Fix command output in style guide

  Show description for 4cbec7f
  schneems

  committed
  4cbec7f

• Fix failing warn_later_doesnt_output_newline test

  Show description for 81cc051
  schneems

  committed
  81cc051

• Refactor output Announcement interface

  Show description for 166974a
  schneems

  committed
  166974a

• Better default errors in fun_run commands

  Show description for dcbb829
  schneems

  committed
  dcbb829

• Update metrics buildpack to use new build output

  schneems

  committed
  a937fff

• Clean up

  schneems

  committed
  d2834db

• Clean up retry logic

  schneems

  committed
  8766545

• Rust 1.73.0 clippy updates

  schneems

  committed
  13736a7

• Do not stream bundle exec rake -P output or bundle list

  Show description for 9351830
  schneems

  committed
  9351830

• Update build output

  schneems

  committed
  5109be8

• Re-run build to demonstrate cached output

  schneems

  committed
  6d16451

• Reduce gem install bundler output

  Show description for b5245dc
  schneems

  committed
  b5245dc

• Include error details on framework error

  schneems

  committed
  14e412e

• Apply suggestions from code review

  Show description for c3909b3
  

  schneems

  and

  edmorley

  committed
  c3909b3

• Update commons/Cargo.toml

  Show description for 2116bc2
  

  schneems

  and

  edmorley

  committed
  2116bc2

• Remove unneeded use newlines and wildcard imports

  schneems

  committed
  362a9c4

• Fix spelling

  schneems

  committed
  de09250

• Format the barnes gem name

  schneems

  committed
  ae799db

• Implement commented out "help" output

  schneems

  committed
  b3ccd76