feat: decouple Rust app's toolchain from rftrace's toolchain #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kröning <[email protected]>
This will allow a standalone static library in the presence of other Rust code. Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
This allows us to use different Rust toolchains for rftrace's static library and the application. Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
While requiring a newer distribution of llvm-tools, this avoids the requirement for linking with lld. Signed-off-by: Martin Kröning <[email protected]>
This fixes builds on Windows. Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the Rust app's toolchain from rftrace's toolchain, allowing you to use a recent nightly version for the Rust app.
The approach is the same that we use for Hermit nowadays: properly bundle
coreandcompiler-builtins-memin the static library, but only export explicit symbols. All other symbols are renamed to avoid duplicated symbols fromcore, which recent Rust toolchains reject.This PR allows me to compile and run rftrace with recent Hermit versions.
I will still rework rftrace for recent Rust versions itself later, though.
This PR is best reviewed commit by commit.
Closes #17