-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed lwip #1
Removed lwip #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Where do inet_*.c
and friends come from?
It's from the debian source code. Ex.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Where do
inet_*.c
and friends come from?It's from the debian source code. Ex.: https://sources.debian.org/data/main/g/glibc/2.28-10/inet/inet_ntoa.c
Do we actually need any new files besides inet_ntoa.c
? Makefile.in
does not have other new files.
Instead of taking them from glibc, can we just use newlib/libc/sys/linux/net/inet_ntoa.c
?
If we really need to add new files from glibc, please add a SPDX License ID and add a link to the source. For example:
/* SPDX-License-Identifier: LGPL-2.1-or-later */
/* From https://sourceware.org/git/?p=glibc.git;a=blob;f=inet/inet_ntoa.c;h=341d8591c30b88d4415898d93ae0dcbd7bf4e3d6;hb=46b5e98ef6f1b9f4b53851f152ecb8209064b26c */
True, i removed the others. If they are needed in the future, they are easy to add back in.
I tried that and it led to a lot of issues, since one linux file typically seeks to have 20 other linux files included with it.
Done |
Removed lwip and replaced all references with interfaces to hermit networking.
Should be merged with hermit-os/hermit-playground#27 to avoid breaking hermit-os/hermit-gcc, as it only pulls the latest commit from newlib.