Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compiler warnings in lens.c, augmatch.c #818

Merged

Conversation

georgehansper
Copy link
Member

Tested with:

./autogen.sh --enable-debug=no --enable-compile-warnings=maximum
make distcheck

and

./autogen.sh --enable-debug=yes --enable-compile-warnings=maximum
make distcheck

Fixes issue #817

@georgehansper
Copy link
Member Author

I've upated this Pull Request along lines of the discussion in #817
ie. to use #define dump_lens_tree(... instead of #if ENABLE_DEBUG...

The end-result is the same (the compiler warning is gone), but it "fits" better with the existing code and is slightly more readable

Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@georgehansper georgehansper merged commit f0a0586 into hercules-team:master Oct 28, 2023
1 check passed
@georgehansper georgehansper deleted the fix_dump_lens_tree branch March 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit function delcaration error with Apple Clang
2 participants