Resolving new elixir version warnings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinst
force-pushed
the
elixir-1.3
branch
4 times, most recently
from
985f0c0 to
ea41625
Compare
kelvinst
commented
Sep 4, 2017
| @@ -5,12 +5,12 @@ defmodule ProgressBar.Mixfile do | |||
| [ | |||
| app: :progress_bar, | |||
| version: "1.6.1", | |||
| elixir: "~> 1.0", | |||
| elixir: "~> 1.3", | |||
There was a problem hiding this comment.
I guess that if phoenix and ecto both depend on elixir 1.3 to work on current versions, we could be a little restrictive for a 1.7.0 release. 😉
There was a problem hiding this comment.
Hah, yeah, this seems reasonable. I'm not scared of bumping major, so we could even make it 2.0. Maybe along with a breaking suffix: change.
Sorry about the nondeterministic specs of #18 fame. I re-ran the build and now it passes…
There was a problem hiding this comment.
No problem at all! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.