Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in handling of gaps in Ahoy inverter number sequence #116

Merged
merged 1 commit into from
Sep 17, 2023
Merged

fix bug in handling of gaps in Ahoy inverter number sequence #116

merged 1 commit into from
Sep 17, 2023

Conversation

dsteinkopf
Copy link
Collaborator

fixes #113

@dsteinkopf dsteinkopf requested a review from 0x7878 September 16, 2023 17:01
@dsteinkopf
Copy link
Collaborator Author

Morgen lass ich es noch probelaufen auf meinem Ahoy. Der Test läuft durch.

0x7878
0x7878 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@0x7878 0x7878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy you also extended the unit tests and added the test_get_ahoy_gap_in_inverter_sequence. For me, it looks solid. Thank you 👍

@0x7878 0x7878 merged commit d4c6ab3 into main Sep 17, 2023
6 checks passed
@dsteinkopf dsteinkopf deleted the bug_113_cannot_handle_gaps branch September 17, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x7878 0x7878 0x7878 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No device in Remote Console visible - Bug: cannot handle gaps in Ahoy inverter number sequence
2 participants
@dsteinkopf @0x7878