tests: on_target: add fota fixture #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/on_target/tests/conftest.py
Outdated
| scan_log_for_assertions(uart_log) | ||
|
|
||
| @pytest.fixture(scope="module") | ||
| def t91x_fota(): |
There was a problem hiding this comment.
we could also make t91x_fota inherit uart from t91x_board, like this:
@pytest.fixture(scope="module")
def t91x_fota(t91x_board):
# Use t91x_board fixture to provide UART functionality to t91x_fota
uart = t91x_board.uart
There was a problem hiding this comment.
I was considering that before going for this solution. The disadvantage is that you then cannot combine it with t91x_trace in case there would be a need. But I can change, maybe it makes more sense i test_fota.py to just have one fixture.
There was a problem hiding this comment.
I think this will be cleanest: def t91x_fota(t91x_board): One would not use the fota fixture without the uart fixture.
Signed-off-by: David Dilner <[email protected]>
jorgenmk
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.