Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectwide: Update sdk-nrf #405

Merged
merged 1 commit into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ jobs:
echo "MEMFAULT_SW_TYPE=${{ inputs.memfault_sw_type }}" >> $GITHUB_ENV
fi

- name: Apply nrf_wifi HAL patch
run: git apply thingy91x-oob/scripts/nrf_wifi_hal_memory_leak_fix.patch --directory=nrfxlib

# Out-of-box firmware build

- name: Build nrf91 firmware
Expand Down Expand Up @@ -189,7 +186,6 @@ jobs:
- name: Apply Connectivity Bridge patch for debug feature
run: |
git apply thingy91x-oob/scripts/debug_feature_nrf.patch --directory=nrf
git apply thingy91x-oob/scripts/debug_feature_zephyr.patch --directory=zephyr

- name: Build nrf53 firmware
working-directory: nrf/applications/connectivity_bridge
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/compliance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
west config manifest.group-filter +bsec
west config build.sysbuild True
west update -o=--depth=1 -n
west blobs fetch hal_nordic

- name: Run Compliance Tests
continue-on-error: true
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/dfu_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
west config manifest.group-filter +bsec
west config build.sysbuild True
west update -o=--depth=1 -n
west blobs fetch hal_nordic

- name: Install dependencies
run: |
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/on_target.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
artifact_run_id:
type: string
required: true
run_log_check_tests:
type: boolean
required: false
default: true
run_fota_tests:
type: boolean
required: false
Expand All @@ -35,6 +39,10 @@ on:
description: The run ID of the workflow to fetch artifacts from
type: string
required: true
run_log_check_tests:
type: boolean
required: true
default: true
run_fota_tests:
type: boolean
required: true
Expand Down Expand Up @@ -125,6 +133,7 @@ jobs:


- name: Run UART tests
if: ${{ inputs.run_log_check_tests }}
working-directory: thingy91x-oob/tests/on_target
run: |
mkdir -p results
Expand Down
10 changes: 0 additions & 10 deletions app/Kconfig.sysbuild

This file was deleted.

7 changes: 7 additions & 0 deletions app/boards/thingy91x_nrf9151_ns.overlay
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,16 @@

chosen {
nordic,modem-trace-uart = &uart1;
zephyr,wifi = &nordic_wlan0;
};
};

&uart1 {
status = "okay";
};


/* Switch to nrf7000 emulation so that scan-only mode is used. */
&nrf70 {
compatible = "nordic,nrf7000-spi";
};
2 changes: 2 additions & 0 deletions app/overlay-memfault.conf
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@ CONFIG_MEMFAULT_NCS_DEVICE_ID_IMEI=y
CONFIG_MEMFAULT_NCS_PROJECT_KEY=""
CONFIG_MEMFAULT_LOGGING_RAM_SIZE=4096
CONFIG_MEMFAULT_HEAP_STATS=y
CONFIG_MEMFAULT_NCS_LOCATION_METRICS=y
CONFIG_MEMFAULT_HTTP_DEDICATED_WORKQUEUE_STACK_SIZE=1560
CONFIG_MEMFAULT_COREDUMP_FULL_THREAD_STACKS=y
20 changes: 12 additions & 8 deletions app/prj.conf
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ CONFIG_RESET_ON_FATAL_ERROR=y
CONFIG_LOG_MODE_DEFERRED=y
CONFIG_LOG_BUFFER_SIZE=4096
CONFIG_DK_LIBRARY=y
CONFIG_POSIX_MAX_FDS=10
CONFIG_ZVFS_OPEN_MAX=10
# CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE=3808 ?
CONFIG_PWM=y

# Heap and stacks
Expand All @@ -19,6 +20,7 @@ CONFIG_MAIN_STACK_SIZE=4096
CONFIG_AT_MONITOR_HEAP_SIZE=2048
# Wifi scan requires extended heap size
CONFIG_HEAP_MEM_POOL_SIZE=40000
CONFIG_HEAP_MEM_POOL_IGNORE_MIN=y
CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=1280

# Enable Networking and Connection Manager.
Expand Down Expand Up @@ -69,6 +71,7 @@ CONFIG_AT_SHELL=y
CONFIG_NRF_CLOUD_COAP=y
CONFIG_NRF_CLOUD_COAP_DISCONNECT_ON_FAILED_REQUEST=y
CONFIG_MODEM_JWT=y
CONFIG_NRF_CLOUD_PRINT_DETAILS=n

# On initial connection to the cloud, add info sections to the shadow
CONFIG_MODEM_INFO=y
Expand Down Expand Up @@ -117,8 +120,8 @@ CONFIG_BUILD_S1_VARIANT=y
CONFIG_COAP_CLIENT_THREAD_PRIORITY=0
CONFIG_COAP_CLIENT_BLOCK_SIZE=1024
CONFIG_COAP_CLIENT_MESSAGE_SIZE=1024
CONFIG_COAP_CLIENT_STACK_SIZE=1024
CONFIG_COAP_EXTENDED_OPTIONS_LEN_VALUE=40
CONFIG_COAP_CLIENT_STACK_SIZE=1792
CONFIG_COAP_EXTENDED_OPTIONS_LEN_VALUE=192

# nRF Cloud
CONFIG_NRF_CLOUD_CLIENT_ID_PREFIX="oob-"
Expand Down Expand Up @@ -158,10 +161,10 @@ CONFIG_LTE_NETWORK_MODE_LTE_M_NBIOT_GPS=y

# configs for Wi-Fi
CONFIG_WIFI=y
CONFIG_WIFI_NRF700X=y
CONFIG_WIFI_NRF700X_SKIP_LOCAL_ADMIN_MAC=y
CONFIG_NRF700X_BH_WQ_STACK_SIZE=1024
CONFIG_NRF700X_IRQ_WQ_STACK_SIZE=1024
CONFIG_WIFI_NRF70=y
CONFIG_WIFI_NRF70_SKIP_LOCAL_ADMIN_MAC=y
CONFIG_NRF70_BH_WQ_STACK_SIZE=1024
CONFIG_NRF70_IRQ_WQ_STACK_SIZE=1024

# Align this with CONFIG_LOCATION_METHOD_WIFI_SCANNING_RESULTS_MAX_CNT
CONFIG_NRF_WIFI_SCAN_MAX_BSS_CNT=10
Expand All @@ -179,7 +182,7 @@ CONFIG_NRF_MODEM_LIB_SHMEM_TX_SIZE=4096
CONFIG_NRF_MODEM_LIB_SHMEM_RX_SIZE=4096

# Scan only using offload API
CONFIG_WPA_SUPP=n
CONFIG_WIFI_NM_WPA_SUPPLICANT=n

# For nRF9160 the default is socket interface
CONFIG_NET_DEFAULT_IF_ETHERNET=y
Expand Down Expand Up @@ -235,3 +238,4 @@ CONFIG_TASK_WDT_CHANNELS=9

# Device power management
CONFIG_PM_DEVICE=y
CONFIG_PM_DEVICE_RUNTIME=n
2 changes: 1 addition & 1 deletion app/sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ tests:
- thingy91x/nrf9151/ns
extra_configs:
- CONFIG_MEMFAULT_NCS_PROJECT_KEY="PROJECTKEY"
extra_args: EXTRA_CONF_FILE=overlay-memfault.conf
extra_args: EXTRA_CONF_FILE="overlay-memfault.conf;overlay-modemtrace.conf;overlay-etb.conf"
tags: ci_build
app.build.bootloader_update:
build_only: true
Expand Down
2 changes: 1 addition & 1 deletion app/src/modules/app/Kconfig.app
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ menu "App"

config APP_MODULE_THREAD_STACK_SIZE
int "Thread stack size"
default 2700
default 2944

config APP_MODULE_WATCHDOG_TIMEOUT_SECONDS
int "Watchdog timeout seconds"
Expand Down
2 changes: 1 addition & 1 deletion app/src/modules/battery/Kconfig.battery
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ menu "Sampler"

config APP_BATTERY_THREAD_STACK_SIZE
int "Thread stack size"
default 1280
default 1536

config APP_BATTERY_WATCHDOG_TIMEOUT_SECONDS
int "Watchdog timeout seconds"
Expand Down
2 changes: 1 addition & 1 deletion app/src/modules/battery/battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ static void sample(int64_t *ref_time)
NPM1300_CHG_STATUS_CC_MASK |
NPM1300_CHG_STATUS_CV_MASK)) != 0;

state_of_charge = nrf_fuel_gauge_process(voltage, current, temp, delta, NULL);
state_of_charge = nrf_fuel_gauge_process(voltage, current, temp, delta, false, NULL);

LOG_DBG("State of charge: %f", (double)roundf(state_of_charge));
LOG_DBG("The battery is %s", charging ? "charging" : "not charging");
Expand Down
2 changes: 0 additions & 2 deletions app/src/modules/fota/fota.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,6 @@ static void fota_task(void)
LOG_ERR("task_wdt_feed, error: %d", err);
SEND_FATAL_ERROR();
return;
} else {
LOG_DBG("Task WDT fed");
}

err = zbus_sub_wait_msg(&fota, &s_obj.chan, s_obj.msg_buf, zbus_wait_ms);
Expand Down
2 changes: 1 addition & 1 deletion app/src/modules/memfault/Kconfig.memfault
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if APP_MEMFAULT

config APP_MEMFAULT_THREAD_STACK_SIZE
int "Thread stack size"
default 2048
default 1536

config APP_MEMFAULT_WATCHDOG_TIMEOUT_SECONDS
int "Watchdog timeout seconds"
Expand Down
4 changes: 2 additions & 2 deletions app/src/modules/transport/Kconfig.transport
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ config APP_TRANSPORT_RECONNECTION_TIMEOUT_SECONDS

config APP_TRANSPORT_THREAD_STACK_SIZE
int "Thread stack size"
default 2048
default 1536

config APP_TRANSPORT_MESSAGE_QUEUE_SIZE
int "Message queue size"
Expand All @@ -25,7 +25,7 @@ config APP_TRANSPORT_MESSAGE_QUEUE_SIZE

config APP_TRANSPORT_WORKQUEUE_STACK_SIZE
int "Workqueue stack size"
default 1536
default 1792
help
Stack size of the module's internal workqueue.

Expand Down
4 changes: 2 additions & 2 deletions app/src/modules/trigger/trigger.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,6 @@ static void blocked_run(void *o)
LOG_DBG("blocked_run");

if (user_object->chan == &LOCATION_CHAN && !user_object->location_search) {
LOG_DBG("Location search done");

if (user_object->trigger_mode == TRIGGER_MODE_NORMAL) {
LOG_DBG("Going into normal state");
smf_set_state(SMF_CTX(&state_object), &states[STATE_NORMAL]);
Expand Down Expand Up @@ -607,6 +605,8 @@ void trigger_callback(const struct zbus_channel *chan)
const enum location_status *location_status = zbus_chan_const_msg(chan);

state_object.location_search = (*location_status == LOCATION_SEARCH_STARTED);

LOG_DBG("Location search %s", state_object.location_search ? "started" : "done");
} else {
/* PRIV_TRIGGER_CHAN event. Frequent Poll Duration timer expired*/
LOG_DBG("Message received on PRIV_TRIGGER_CHAN channel.");
Expand Down
8 changes: 8 additions & 0 deletions app/sysbuild.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#
# Copyright (c) 2024 Nordic Semiconductor ASA
#
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
#

SB_CONFIG_WIFI_NRF70=y
SB_CONFIG_WIFI_NRF70_SCAN_ONLY=y
1 change: 0 additions & 1 deletion app/sysbuild/mcuboot/prj.conf
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
CONFIG_PM=n

CONFIG_MAIN_STACK_SIZE=10240
CONFIG_MBEDTLS_CFG_FILE="mcuboot-mbedtls-cfg.h"

CONFIG_BOOT_SWAP_SAVE_ENCTLV=n
CONFIG_BOOT_ENCRYPT_IMAGE=n
Expand Down
12 changes: 0 additions & 12 deletions scripts/nrf_wifi_hal_memory_leak_fix.patch

This file was deleted.

1 change: 1 addition & 0 deletions tests/lib/simple_config/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ target_compile_options(app
-DCONFIG_COAP_CLIENT_MESSAGE_HEADER_SIZE=48
-DCONFIG_COAP_CLIENT_MESSAGE_SIZE=512
-DCONFIG_COAP_CLIENT_MAX_REQUESTS=2
-DCONFIG_COAP_CLIENT_BLOCK_SIZE=1024
)
5 changes: 2 additions & 3 deletions tests/on_target/tests/test_uart_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@ def test_uart_output(t91x_board, hex_file):
patterns_boot = [
"Network connectivity established",
"Connected to Cloud",
"trigger: frequent_poll_entry: frequent_poll_entry",
"trigger: trigger_work_fn: Sending data sample trigger",
"battery: sample: State of charge:",
"environmental_module: sample: temp:",
"transport: state_connected_ready_run: Payload",
"blocked_run: Location search done",
"trigger: frequent_poll_entry: frequent_poll_entry"
"Location search done"
]
patterns_button_press = [
"trigger: frequent_poll_run: Button 1 pressed in frequent poll state, restarting duration timer",
Expand Down
2 changes: 1 addition & 1 deletion west.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ manifest:
- name: nrf
remote: ncs
repo-path: sdk-nrf
revision: cfb2a11d013959f2fa68a1dc9460a1cf1c6fda82
revision: dd1b59877d3bf2aff976bc3c3a2a0dca135d9f85
import: true
Loading