Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC-456 adding versioned method/RPC handlers to be able to clearly separate the different algos #8

Merged
merged 1 commit into from
Sep 6, 2024
Merged

RPC-456 adding versioned method/RPC handlers to be able to clearly separate the different algos #8

merged 1 commit into from
Sep 6, 2024

Conversation

dmitriy-helius
Copy link
Collaborator

Overview

  • Adding two distinctly named method getPriorityFeeEstimateV1 and V2 and calling V1 from getPriorityFeeEstimate. In the future we'll just switch to calling V2. that way we can keep support for V1 for a time been

Testing

  • With unit tests and locally

@dmitriy-helius dmitriy-helius self-assigned this Sep 5, 2024
@dmitriy-helius dmitriy-helius merged commit 57e7fe9 into main Sep 6, 2024
2 checks passed
@dmitriy-helius dmitriy-helius deleted the 456 branch September 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vovkman vovkman Awaiting requested review from vovkman

Assignees

@dmitriy-helius dmitriy-helius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmitriy-helius