Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests consistency and clean up #1085

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix tests consistency and clean up #1085

merged 1 commit into from
Nov 7, 2024

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Nov 7, 2024

This PR improves:

  • Tests consistency with Helidon guidelines
    • class package visibility
    • method package visibility
  • Clean up
    • IDE warnings
    • unused import
    • unused field

@tvallin
Test clean up
aa476fc 
Signed-off-by: tvallin <[email protected]>
@tvallin tvallin self-assigned this Nov 7, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 7, 2024
@romain-grecourt romain-grecourt merged commit 5db351f into helidon-io:master Nov 7, 2024
24 checks passed
@tvallin tvallin deleted the test-cleanup branch November 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees

@tvallin tvallin

Labels
4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvallin @romain-grecourt