Skip to content

Commit

Permalink
Update sysroot notes now that #82 is closed
Browse files Browse the repository at this point in the history
  • Loading branch information
cpsauer committed Feb 22, 2023
1 parent d7a2830 commit 19808d6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions refresh.template.py
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,8 @@ def _all_platform_patch(compile_args: typing.List[str]):
# For more context see: https://github.com/hedronvision/bazel-compile-commands-extractor/issues/21
compile_args = (arg for arg in compile_args if not arg == '-fno-canonical-system-headers')

# Swap -isysroot for --sysroot to work around (probably) https://github.com/clangd/clangd/issues/1305
# For context, see https://github.com/clangd/clangd/issues/1305
# Swap -isysroot for --sysroot to work around some unknown sysroot bug in clangd.
# For context, see https://github.com/hedronvision/bazel-compile-commands-extractor/issues/82
# The = logic has to do with clang not accepting -isysroot=, but accepting --sysroot=. Note that -isysroot <path> is accepted, though undocumented.
compile_args = ('-isysroot'+arg[len('--sysroot')+arg.startswith('--sysroot='):] if arg.startswith('--sysroot') else arg for arg in compile_args)

Expand Down

0 comments on commit 19808d6

Please sign in to comment.