Enhancements #244
Merged
Enhancements #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat can be copied for regions
…dy region output folder when generating resources, as per #230
…ut directory and list all generate resources including data, data dictionaries, figure and maps, reports generated along with an advisory note to inspect and confirm appropriateness of outputs prior to dissemination); also amended Docker image to add pygeometa to support generation of metadata (not yet implemented) and remove the platform specific Docker build variable (more experimentation required; this may have caused an issue for an ARM64 platform based user)
…verall study region results summary name from 'city' to 'region' (as someone may use it just for a specific area, that could be a sub-part of a city, or not a city at all)
…(the latter has slow read/write with non-concurrent access that can cause problems; also results in redundant read/writes as data is already written to be read from the database. This commit address #216
…to graphml; we were already writing unprojected nodes/edges to the geodatabase --- by instead writing the projected ones, we could reload these in network analysis step via graph_from_ gdfs using OSMnx and avoid reading/writing graphml as an extra step. This addresses #216. There is a n oddity -- while end results are basically similar (some slight variation in walkability), the number of edges (presumably returned from graph_from_gdfs) was approximately halved for Las Palmas, conseque ntly the sample points are approximately halved too. More exploration required to understand why this is the case, but perhaps its to do with network directionality... In any case - results are mostly t he same while things run faster/more efficiently/less storage space. So retaining code using this com mit and then will explore.
…bstracting the core functions (configure OSMnx, generate network, clean intersections, create pgrouting topology); this will make it easier to investigate for discussion #235
…(corrected implementation of this)
curs in the generate resources stage
… one sample point is retained at junction of multiple roads, not multiple)
…as some duplicated loading of edges, nodes from gdfs -- so this was consolidated, and some of the variable names simplifed, removing 'gdf' prefix where not really needed)
…hood analyses script
…or tagging with date in the dockerfile (#236)
…dy region urban intersection using custom boundary when the urban query and urban region have been otherwise defined (#239)
… 'weight' (integer; derived from length) as per #243, as the additional lines of code appear redundant (no tangible time benefit at a negligible cost in precision, not justifying the additional complexity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update, as per discussion in #235. In particular, it addresses:
Because of the urgency of issue #242, and the extensive discussion and investigations testing the changes reported in #235 and related issues, I will merge this pull request.