Address an edge case issue where sample points aren't associated with grid ids, causing a type error and failure to run #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #214 , while experimenting with a non-traditional population grid (Australian 1km population grid, not from GHSL) the neighbourhood analysis script crashed due to an issue with sample points not associated with grid ids. I tightened up the logic in our spatial join to address this, and did a slight refactor of our filtering code to make this more compact/readable.
I have since test ran the updated code for Las Palmas and Melbourne successfully (notwithstanding a seperate issue for Melbourne #212; unfortunately current resolution for this is 'run again' -- i'll try to find time to solve more elegantly).
While doing this it reminded me of more work to be done refactoring, but I tried to keep this one small and focused. I think its okay to merge, but wanted to pass out for review.