Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Labeled Tuples #1235

Draft
wants to merge 120 commits into
base: dev
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
120 commits
Select commit Hold shift + click to select a range
3d2a351
labeled tuple rewrite
WondAli Feb 23, 2024
6889f4f
Merge branch 'dev' into labeled-tuple-rewrite
WondAli Feb 23, 2024
c137ded
working dot operator + bug fixes to precedence
WondAli Mar 23, 2024
5af500f
may need to revert some tuplabel code since no longer consistent with…
WondAli Mar 31, 2024
9927605
allow for unmatched labels in one direction
WondAli Apr 13, 2024
55500e6
updated casting for labels
WondAli Apr 22, 2024
f08c114
left-associativity for dot operator
WondAli Apr 25, 2024
7ab1470
dot now treats labels as tuples of size 1
WondAli Apr 25, 2024
1cdeb3a
multiple bug fixes and implemented labels as function arguments. TODO…
WondAli Apr 28, 2024
0598c9c
code cleanup, quality improvement. Also fixes to casting (mostly)
WondAli Jun 7, 2024
b3e7c84
casting bug fix
WondAli Jun 7, 2024
dfdf051
merged with dev
WondAli Jun 7, 2024
07275db
minor changes to dot in statics and matching
WondAli Jun 25, 2024
44841b8
standalone labels as singleton tuples + shifting error handling for u…
WondAli Jun 28, 2024
56d9a50
fixed bug concerning rearranging function arguments
WondAli Jul 3, 2024
3d294dd
documentation in progress
WondAli Jul 30, 2024
cbe3125
merge complete
WondAli Jul 31, 2024
e0952df
renamed some variables to be more accurate
WondAli Aug 8, 2024
bf1137c
dot operator update
WondAli Aug 12, 2024
9ab0f49
dot operator static fixes
WondAli Aug 16, 2024
db194f8
Creation of Label term, bug fixes, documentation updates
WondAli Aug 23, 2024
c20706a
fixes to labeled expressions as singleton tuples
WondAli Aug 24, 2024
fe24986
minor test_elaboration update
WondAli Aug 24, 2024
773fa9b
singleton tuple fixes
WondAli Aug 27, 2024
e76f5e2
fix statics to check for mismatched labels
WondAli Aug 27, 2024
a802eb7
fix to let elaboration so that dot operators operate on annotated typ…
WondAli Aug 28, 2024
65eec8e
merge (not working)
WondAli Sep 12, 2024
4753f3f
fix to precedence and cast ground_caes_of
WondAli Sep 13, 2024
cae4bb5
elaborator fixes
WondAli Sep 13, 2024
bc22754
updated parser for dot operator
WondAli Sep 13, 2024
e810400
debug
7h3kk1d Sep 20, 2024
840f06f
Temp commit
7h3kk1d Sep 21, 2024
58fc12c
Add rearrange2
7h3kk1d Sep 21, 2024
2b1eda8
I got some version of elaboration working
7h3kk1d Sep 21, 2024
2be5a46
Fix formatting
7h3kk1d Sep 21, 2024
f7a2666
Cleanup
7h3kk1d Sep 23, 2024
a2c34df
Revert makefile changes
7h3kk1d Sep 23, 2024
50536fe
Cleanup debugging code
7h3kk1d Sep 23, 2024
4226bb4
More cleanup
7h3kk1d Sep 23, 2024
8eef13c
Got a version of evaluation to work
7h3kk1d Sep 23, 2024
998caeb
Stop elaborating labels in Dot
7h3kk1d Sep 27, 2024
000b853
updates to elaboration, label extraction, ap in progress
WondAli Sep 27, 2024
76247f0
merged with labeled-tuple-rewrite
WondAli Sep 27, 2024
8379dec
Missing labeled tuple labels elboration (#1399)
WondAli Sep 27, 2024
d5dfa8f
cleaned LabeledTuple util file
WondAli Sep 27, 2024
7d707c9
Rearranging does not occur past elaboration. Functions reworked to al…
WondAli Sep 29, 2024
20c51f9
Add support for fast_equal on TupLabel expressions
7h3kk1d Oct 2, 2024
49c11d9
Add test for elaboration adding labels to labeled tuples
7h3kk1d Oct 2, 2024
38b10c1
Inline expectation
7h3kk1d Oct 2, 2024
c315caa
Fix typos
7h3kk1d Oct 2, 2024
5707718
Add test for rearranging labels during elaboration
7h3kk1d Oct 2, 2024
e4fb061
Merge remote-tracking branch 'origin/dev' into labeled-tuple-rewrite
7h3kk1d Oct 2, 2024
8d6528e
Add test for labeled tuple projection evaluation
7h3kk1d Oct 2, 2024
a5c83bc
Add statics test for labeled parameter in function
7h3kk1d Oct 2, 2024
f4d778e
Added tests to assure that types are inconsistent when unlabeled vari…
7h3kk1d Oct 4, 2024
32173ea
removed function implicit labelling and rearranging in type consisten…
WondAli Oct 4, 2024
318cfb3
Add basic elaboration tests for singleton tuples
7h3kk1d Oct 11, 2024
c8ef191
Modify singleton labeled tuple elaboration
7h3kk1d Oct 11, 2024
22cd8d6
Add parser tests for singleton tuples
7h3kk1d Oct 11, 2024
f04c976
Wrap all tuplabels in tuples in parser
7h3kk1d Oct 11, 2024
78e817c
Remove is_contained logic
7h3kk1d Oct 11, 2024
7008809
More tests
7h3kk1d Oct 13, 2024
59ff548
Add assertions that there's no static errors in static tests
7h3kk1d Oct 13, 2024
158a62d
Merge branch 'dev' into labeled-tuple-rewrite
7h3kk1d Oct 13, 2024
0669d9c
Ensure more tests are fully consistent
7h3kk1d Oct 13, 2024
c27642b
Stop recalculating statics in tests
7h3kk1d Oct 13, 2024
bcd9fe2
Add support for displaying TupLabel with label and type in view_ty fu…
7h3kk1d Oct 13, 2024
926c5c7
Add labeled tuples doc page
7h3kk1d Oct 14, 2024
5f790cb
revert scratch file
7h3kk1d Oct 14, 2024
39cbba1
Revert init.ml
7h3kk1d Oct 14, 2024
b242321
Add sdocumentation page for labeled tuples
7h3kk1d Oct 14, 2024
de85c69
Tests for multiple labels
7h3kk1d Oct 14, 2024
3c36566
Update Makefile to include dev profile in watch-test
7h3kk1d Oct 14, 2024
72b4cac
Add test case for singleton labeled tuple adding label
7h3kk1d Oct 14, 2024
828da51
Make labeled tuple not need parens in display
7h3kk1d Oct 14, 2024
7688a2b
Add test case for let statement that adds labels during elaboration
7h3kk1d Oct 14, 2024
c86e5f0
Add support for lifting single values into a singleton labeled tuple …
7h3kk1d Oct 14, 2024
dac5119
Refmt
7h3kk1d Oct 14, 2024
3420d2c
Additional test for singleton labels
7h3kk1d Oct 14, 2024
1fa320c
SIngleton labels kind of work
7h3kk1d Oct 14, 2024
c87048d
Remove singleton product from type view
7h3kk1d Oct 14, 2024
01f84c5
Fix the duplicate singleton label statics
7h3kk1d Oct 15, 2024
e018126
Fix stack overflow
7h3kk1d Oct 15, 2024
11804a2
Fix warning in test statics
7h3kk1d Oct 15, 2024
523177e
First attempt singleton labeled tuple elaboration
7h3kk1d Oct 15, 2024
c4db0d0
Remove debug comment
7h3kk1d Oct 16, 2024
03208ff
Fix test
7h3kk1d Oct 16, 2024
0f8521a
More singleton label elaborator fixes
7h3kk1d Oct 16, 2024
1bee9bb
Update init
7h3kk1d Oct 18, 2024
e66dd80
Add tests for singleton labeled argument function application
7h3kk1d Oct 18, 2024
b42c613
Progress on elaborating singleton tuples with mismatched labels
7h3kk1d Oct 21, 2024
9a918ef
Fix warnings
7h3kk1d Oct 21, 2024
a603ae7
Merge remote-tracking branch 'origin/dev' into labeled-tuple-rewrite
7h3kk1d Oct 30, 2024
61937e7
Merge remote-tracking branch 'origin/dev' into labeled-tuple-rewrite
7h3kk1d Oct 31, 2024
d88395e
Closer to getting singleton labeled tuples to work
7h3kk1d Oct 31, 2024
7c5abb5
Fix unused warnings
7h3kk1d Nov 1, 2024
d163367
Errored statuses showed up right
7h3kk1d Nov 1, 2024
0343f51
Extract functions to be slightly more legible
7h3kk1d Nov 1, 2024
8d3d3e6
Merge branch 'dev' into labeled-tuple-rewrite
7h3kk1d Nov 1, 2024
12eef70
Fixed singleton labeled tuple in function application
7h3kk1d Nov 4, 2024
868ed9b
Fix statics test
7h3kk1d Nov 4, 2024
effab75
Merge remote-tracking branch 'origin/dev' into labeled-tuple-rewrite
7h3kk1d Nov 7, 2024
d1cd408
Add some information on the lifted type to the cursor inspector
7h3kk1d Nov 8, 2024
ece70b4
label uniqueness checking
WondAli Nov 10, 2024
3624020
Start elaborating singleton labeled tuple patterns
7h3kk1d Nov 8, 2024
ecbd7ce
Singleton labeled tuple pattern elaboration disabled under ascription
7h3kk1d Nov 15, 2024
24de2fa
Fix assertions
7h3kk1d Nov 15, 2024
58029ad
Stop debugging
7h3kk1d Nov 15, 2024
69fb726
Remove unnecessary module name
7h3kk1d Nov 15, 2024
4a78f89
Fix tests and strip casts out of some of the tests
7h3kk1d Nov 15, 2024
30e3b9c
Bugfix: statics now check that the first argument in a TupLabel is a …
WondAli Nov 18, 2024
5529383
Progress on improving cursor inspector for automatic labelling
7h3kk1d Nov 18, 2024
4a8776c
Fix unused module open
7h3kk1d Nov 18, 2024
7166f28
Add sugar to info
7h3kk1d Nov 18, 2024
6e71d52
Add more labeling information to cursor inspector
7h3kk1d Nov 21, 2024
ddaaaa9
Add pattern labels to cursor inspector
7h3kk1d Nov 26, 2024
88931f4
Remove lifted_ty from Info types
7h3kk1d Nov 26, 2024
3a96a5a
Cursor inspector changes
7h3kk1d Dec 5, 2024
68f85ab
updated dot operator to use labels
WondAli Dec 6, 2024
bd36673
Fix cursor inspector message
7h3kk1d Dec 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More singleton label elaborator fixes
7h3kk1d committed Oct 16, 2024

Verified

This commit was signed with the committer’s verified signature.
7h3kk1d Alexander Bandukwala
commit 0f8521a6ddae2c2dbef5886cc2d90d21acadb714
25 changes: 22 additions & 3 deletions src/haz3lcore/dynamics/Elaborator.re
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ let rec fresh_cast = (d: DHExp.t, t1: Typ.t, t2: Typ.t): DHExp.t => {
switch (t2.term) {
| Prod([{term: TupLabel({term: Label(l), _}, t), _}]) =>
switch (t1.term) {
| Prod([{term: TupLabel({term: Label(l'), _}, t'), _}]) when l == l' =>
| Prod([{term: TupLabel({term: Label(l'), _}, _), _}]) when l == l' =>
Typ.eq(t1, t2)
? d
: {
@@ -42,6 +42,7 @@ let rec fresh_cast = (d: DHExp.t, t1: Typ.t, t2: Typ.t): DHExp.t => {
|> DHExp.fresh
}
| _ =>
// TODO Remove duplication in cases
Typ.eq(t1, t2)
? d
: {
@@ -480,7 +481,15 @@ let rec elaborate =
let def = add_name(Pat.get_var(p), def);
let (def, ty2) = elaborate(m, def);
let (body, ty) = elaborate(m, body);
Exp.Let(p, fresh_cast(def, ty2, ty1), body)
Exp.Let(
p,
fresh_cast(
def,
Typ.weak_head_normalize(ctx, ty2),
Typ.weak_head_normalize(ctx, ty1),
), // TODO abanduk: Is it safe to normalize here?
body,
)
|> rewrap
|> cast_from(ty);
} else {
@@ -489,7 +498,17 @@ let rec elaborate =
let def = add_name(Option.map(s => s ++ "+", Pat.get_var(p)), def);
let (def, ty2) = elaborate(m, def);
let (body, ty) = elaborate(m, body);
let fixf = FixF(p, fresh_cast(def, ty2, ty1), None) |> DHExp.fresh;
let fixf =
FixF(
p,
fresh_cast(
def,
Typ.weak_head_normalize(ctx, ty2),
Typ.weak_head_normalize(ctx, ty1),
),
None,
)
|> DHExp.fresh; // TODO abanduk: Is it safe to normalize here?
Exp.Let(p, fixf, body) |> rewrap |> cast_from(ty);
};
| FixF(p, e, env) =>
39 changes: 39 additions & 0 deletions test/Test_Elaboration.re
Original file line number Diff line number Diff line change
@@ -440,4 +440,43 @@ let elaboration_tests = [
),
)
),
test_case(
"Singleton labeld tuple analysis adds label with type alias", `Quick, () =>
alco_check(
{|type T = (a=String) in
let x : T = "hello" in x|},
Let(
Var("x") |> Pat.fresh,
Tuple([
TupLabel(Label("a") |> Exp.fresh, String("hello") |> Exp.fresh)
|> Exp.fresh,
])
|> Exp.fresh,
Var("x") |> Exp.fresh,
)
|> Exp.fresh,
dhexp_of_uexp(
parse_exp({|type T = (a=String) in let x : T = "hello" in x|}),
),
)
),
test_case(
"Singleton labeld tuple analysis adds label with type alias", `Quick, () =>
alco_check(
{|let zip_only : (zip=Int) = (zip=12345) in zip_only|},
Let(
Var("zip_only") |> Pat.fresh,
Tuple([
TupLabel(Label("zip") |> Exp.fresh, Int(12345) |> Exp.fresh)
|> Exp.fresh,
])
|> Exp.fresh,
Var("zip_only") |> Exp.fresh,
)
|> Exp.fresh,
dhexp_of_uexp(
parse_exp({|let zip_only : (zip=Int) = (zip=12345) in zip_only|}),
),
)
),
];