Error flag for case expressions' associated DHExp #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to merge the three different case constructs in
DHExp
into one case construct.The new approach will replace
DHExp.ConsistentCase(DHExp.case)
,DHExp.InconsistentBranches(MetaVar.t, HoleInstanceId.t, DHExp.case)
,DHExp.InexhaustiveCase(MetaVar.t, HoleInstanceId.t, DHExp.case)
(added for #1124),and
DHExp.case.Case(t, list(rule), int)
with
DHExp.Case(t, list(rule), int, option((MetaVar.t, HoleInstanceId.t)))
, in which the last parameter indicates whether the corresponding case expression is inconsistent.Two concerns:
DHExp.constructor_string
? If so, the newCase
construct, as well as the functionDHExp.constructor_string
would be a little bit more complex.option
might not be enough.