Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting implementation of incon judgment into Hazel 3. #1094

Merged
merged 11 commits into from
Oct 22, 2023

Conversation

DavidFangWJ
Copy link
Contributor

This branch is created by porting Constraint.re and Incon.re into Hazel 3 (aka branch dev). It has not yet been tested, and the treatment of lists is potentially incorrect.

@cyrus- cyrus- changed the base branch from dev to haz3l-case-exhaustiveness September 24, 2023 23:29
@cyrus-
Copy link
Member

cyrus- commented Sep 24, 2023

Changed the base branch to #1114 since this is a component of that PR. I will let the authors of that PR review this code first. @DavidFangWJ you should make sure you are in communication with them and you can get involved in that PR (or start working on redundancy checking) once you feel good about the implementation here.

@pigumar1
Copy link
Contributor

Constraint.re and Incon.re have already been merged into #1114.
What is left on this branch is the implementation of wrapping an inexhaustive case expression with an error whole in the dynamic view.

@pigumar1 pigumar1 changed the base branch from haz3l-case-exhaustiveness to haz3l-case-advanced-ui October 22, 2023 18:19
@pigumar1 pigumar1 marked this pull request as ready for review October 22, 2023 18:44
@pigumar1
Copy link
Contributor

Merging this pull request into #1125 .
Reviewing is deferred. The code in this pull request will be reviewed in that pull request.

@pigumar1 pigumar1 merged commit 57b8a76 into haz3l-case-advanced-ui Oct 22, 2023
1 check passed
@pigumar1 pigumar1 deleted the haz3l-incon branch October 22, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants