Augment Specs and Other Edits #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow stacked bar charts, the values attribute needs to handlemultiple properties separated by commas. Previous implementation included a workaround that updates the accessor spec during runtime to accomodate the multiple properties. Changes have been made to settings.js to allow accessors with higher dimensions. This view has been refactored to take advantage of these changes.
When there are no items plottable (may be the result of no datasets provided or no x and y data provided), xDiff or yDiff may be infinity and the code would crash when they're divided by xInterval or yInterval. Checks have been added to only undergo these processing when the values are finite.
|
@karger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.