Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash in proxyUrl #5

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Conversation

kevincheng96
Copy link
Contributor

Infura has trouble handling requests with a trailing slash in API endpoint. INFURA/infura#221

Credit to 🍯 for the find

Infura has trouble handling requests with a trailing slash in API endpoint. INFURA/infura#221

Credit to 🍯 for the find
@kevincheng96
Copy link
Contributor Author

Cleaned up the fix a bit by directly sanitizing trailing slashes from the proxyUrl instead of changing pathname.

@kevincheng96
Copy link
Contributor Author

Cleaned up the fix a bit by directly sanitizing trailing slashes from the proxyUrl instead of changing pathname.

Nevermind, reverted back to the original change since it 👨‍🍳 pointed out that it's actually more correct. We'll leave pathname untouched if it's actually defined as something other than "/".

@hayesgm hayesgm merged commit f491449 into hayesgm:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants