Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream model manager to ComfyUI core #51

Open
huchenlei opened this issue Nov 13, 2024 · 2 comments
Open

Upstream model manager to ComfyUI core #51

huchenlei opened this issue Nov 13, 2024 · 2 comments

Comments

@huchenlei
Copy link

Hi @hayden-fr,

Thank you for your excellent contributions on both ComfyUI-Model-Manager and ComfyUI-Image-Browsing. The features you've implemented address two critical gaps in ComfyUI's functionality that would benefit the entire user base.

I'd like to propose upstreaming both projects to the core repositories (ComfyUI_frontend and ComfyUI). This integration could help standardize these essential features for all users.

If you're interested in discussing this further, I'm available on the ComfyUI Discord server (username: HCL). I'd be happy to help facilitate the process or discuss any concerns you might have.

@hayden-fr
Copy link
Owner

Thx for invitation.

There are some questions. If upstreaming the project to the core repository, how should I resolve the conflict for users who already have the extension installed. I mean what should I do to avoid possible conflict like duplication UI, and whether users who have installed extensions need to be prompted to remove existing, etc

@huchenlei
Copy link
Author

We currently have a disabled extension list that you can use to disable extensions that have been upstreamed to core: https://github.com/Comfy-Org/ComfyUI_frontend/blob/ee5c1271461f90194dfa032d61f035d49a52eeab/src/stores/extensionStore.ts#L71-L83

You can just add Comfy.ModelManager there to bypass the extension hooks after you upstreamed the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants