Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add preview lora, checkpoint thumbnail #739

Open
1 task done
EasyComfyui opened this issue Sep 5, 2024 · 8 comments
Open
1 task done

[Feature Request]: Add preview lora, checkpoint thumbnail #739

EasyComfyui opened this issue Sep 5, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@EasyComfyui
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Add preview lora, checkpoint thumbnail

Proposed workflow

  1. Go to ....
  2. Press ....
  3. ...

Additional information

image

@EasyComfyui EasyComfyui added the enhancement New feature or request label Sep 5, 2024
@mcmonkey4eva
Copy link
Contributor

the new Model library sidebar tab includes metadata previews. It's a bit of an MVP (only counts metadata in the safetensors header, not those added in eg auto1111 format or anything, and doesn't provide a way to edit). Also doesn't yet account for the model list on a node dropdown

@EasyComfyui
Copy link
Author

the new Model library sidebar tab includes metadata previews. It's a bit of an MVP (only counts metadata in the safetensors header, not those added in eg auto1111 format or anything, and doesn't provide a way to edit). Also doesn't yet account for the model list on a node dropdown

image
i can't see @@

@EasyComfyui
Copy link
Author

image

@mcmonkey4eva
Copy link
Contributor

I think your comfy install is outdated

@EasyComfyui
Copy link
Author

Tôi nghĩ rằng cài đặt thoải mái của bạn đã lỗi thời

image
Too bad it doesn't show up by name

@universorum
Copy link

Since ComfyUI released, there in no built-in method to allow user to preview the image of lora/checkpoint. The only way to do that is using a third-party extension. Now we have a built-it sidebar to make selecting model easier but user cannot view the image of the model still. It may be confused when user who have a many models with same concept.

I strongly hope that the UI can show the preview image as A1111 logic. That can let someone like me who often switch the inferencer between A1111 and Comfy more easier to manage the Models.

I noticed that the Comfy API does not return the preview image information in the response. Maybe I should open the issue at main repo?

BTW: Given that this is a very common requirement, I cannot image that this idea never issued at the main repo. But I cannot find the issue by a keyword.

@LukeG89
Copy link

LukeG89 commented Nov 19, 2024

@universorum There is the possibility that Model Library will be replaced... Who knows!

@huchenlei proposed to the developer of ComfyUI-Model-Manager and ComfyUI-Image-Browsing to integrate both extensions into core.

@mcmonkey4eva
Copy link
Contributor

Comfy's server currently only returns model metadata, not secondary files, ie if you apply the images in ModelSpec format, Comfy's model browser will see them. If you use SwarmUI to edit model metadata, this is used by default.
Swarm autoreads metadata from other known formats so can compress them for you. When I was working at Comfy Org I had the goal of eventually porting over most of that logic so Comfy could natively read many different metadata formats too, but I didn't get around to that while I was there, so hopefully somebody else will. In the meantime until that's done, you can use Swarm to get all your metadata into standardized format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants