Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defcustom/defgroup addition & menubar #76

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

ayman
Copy link
Contributor

@ayman ayman commented Oct 7, 2013

Adding defcustom and defgroup for easy config and adding a pretty menubar menu.

image

@voidlily
Copy link

+1

@xmaillard
Copy link
Contributor

Oh ! I did not pay attention enough. There is great stuff into your patch too.

Maybe we should try to converge our 2 patches. Yours with easymenu support would be greatly appreciated !

@ayman
Copy link
Contributor Author

ayman commented Jan 5, 2015

Converge would be best IMHO - but the menubar stuff is easy to rip out into
a second request of there's no defcustom stuff of mine that you want to use.

On Mon, Jan 5, 2015 at 2:32 AM, Xavier Maillard [email protected]
wrote:

Oh ! I did not pay attention enough. There is great stuff into your patch
too.

Maybe we should try to converge our 2 patches. Yours with easymenu support
would be greatly appreciated !


Reply to this email directly or view it on GitHub
#76 (comment)
.

@xmaillard
Copy link
Contributor

I am trying to clean up my patch and submit it again. Maybe you could then try to rebase your work on it ?

Regards

@ayman
Copy link
Contributor Author

ayman commented Mar 15, 2015

Thanks. I'll work on a rebase and update soon.

@ayman
Copy link
Contributor Author

ayman commented Mar 15, 2015

Updated things - pull request just adds menubar functionality and the :prefix "twittering-" to the defgroup.

@cvmat
Copy link
Collaborator

cvmat commented Sep 6, 2015

Thank you for your contribution. I am sorry to have kept you waiting.
I have commited your patch as 0ed6805 and fixed it as 44854d9 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants