Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gamecontroller db, allow user mappings #659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

madrazo
Copy link
Contributor

@madrazo madrazo commented Nov 20, 2019

update game controller database,
work around large string size limits,
add mappings for ios android,
allow mappings from a "gamecontrollerdb.txt" file (see https://github.com/gabomdq/SDL_GameControllerDB )

update game controller database,
work around large string size limits,
add mappings for ios android
@thomasuster
Copy link
Member

Hey @madrazo , would you open an issue with a descriptive problem statement? And then from this issue say "This fixes #123" where 123 is the issue number you filed? Otherwise I'm unable to review this diff as I'm not sure what it addresses.

@madrazo
Copy link
Contributor Author

madrazo commented Nov 21, 2019

@thomasuster yes, also dont't pull it yet as still has an issue getting the string correct size

using strlen instead of sizeof
@thomasuster
Copy link
Member

thomasuster commented Nov 23, 2019

This PR implements #660

@thomasuster
Copy link
Member

Rekicked CI to see if it passes.

@thomasuster
Copy link
Member

Any idea why CI isn't passing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants