-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distortion fixes #2395
base: master
Are you sure you want to change the base?
Distortion fixes #2395
Conversation
Don't worry guys. I'm planning on finishing both this and the hud pull today. |
I started work on this branch today, fixing up some menus for the release. I tested with 720p resolution. I created a pull request with my progress here. |
Not going to happen for this release. Do we still even want it? Or is displaying more level than was designed for going to be a problem? |
de2bca9
to
20307b1
Compare
I think expanding the view of the level is the wrong way to go. Some levels are just going to look odd having so much visible at the same time. Perhaps we should have a fullscreen mode with no zoom that just fills the rest of the screen with black. Only thing it would really fix is the issue with running the game in windowed mode that Windows 8 has (#2293). Possibly also having the option to have the scaled version that is already in game for those who don't mind the weird pixel scaling that occurs. |
Is it possible for the windowed mode proportions be scaled but not stretched and the rest of the screen filled with black? |
Probably but I think most screens probably don't have the resolution to scale without stretching. The game is currently 1056 x 672 so the next time it scaled, the screen would have to be 2112 x 1344. I think. Most of the game is already scaled up from 528 x 336 so we might be able to do a x 1.5 scale |
Oh I wasn't suggesting 2112x1344, that's way to big. Any scaling that's not a whole number is going to end up with some distortion so I don't think 1.5 would work. What if we choose between scaling factors based on the screen size? So if the screen is < 1056 x 672 then the fullscreen resolution is 528 x 336 with black around it. Then if the screen is > 1056 x 672 but < 2112 x 1344 set the scaling to 2X so the game runs at 1056 x 672 but with black boxes etc. |
Replaces #2327 - removing the level changes & adding nimau's black bar commit caused merge errors and I turned it into a mess trying to fix it so thought it'd be easier to have a new branch. Still a WIP.