Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedwords as QRCode #1465

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Seedwords as QRCode #1465

wants to merge 5 commits into from

Conversation

XMRZombie
Copy link
Contributor

@XMRZombie XMRZombie commented Dec 12, 2024

Uses net.glxn.qrgen.QRCode to show seedwords as a QRCode for external wallet backup
qrcode

Uses net.glxn.qrgen.QRCode to show seedwords as a QRCode for external wallet backup
@XMRZombie XMRZombie requested a review from woodser as a code owner December 12, 2024 18:53
@KewbitXMR
Copy link

MITM risk vector IMO over only small convenience.

Summaries:
- Restored lost code parts.
- Added UI updates
- Using char for memory safe seed usage
@XMRZombie
Copy link
Contributor Author

@KewbitXMR MITM risk means you're looking your seedwords while having somebody close to you.
That's an opsec issue but why not blurring seedwords and qrcode

Removing unused import
Using cakewallet's QR Code format 
```String formattedSeed = "monero-wallet:?seed=" + seedWords.replace(" ", "+");```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants