Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color and systemctl install for using hauler to serve images/files #181

Closed
wants to merge 2 commits into from

Conversation

clemenko
Copy link
Contributor

Add color and systemctl install for using hauler to serve images/files

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?
Adding systemd logic

What is the current behavior?
N/A

What is the new behavior (if this is a feature change)?
adds systemd file for starting hauler as a daemon

  • Start registry service - 'systemctl start hauler@regsitry'.
  • Start fileserver service - 'systemctl start hauler@fileserver'.

Does this PR introduce a breaking change?
Nope

Other information:
cute animal picture.
360_F_643119209_iLHJkoQExXcgYYQw0zYKurptxQXAAjlr

@amartin120
Copy link
Contributor

I almost insta-merged just because you included an animal pic.

@amartin120 amartin120 requested a review from dweomer February 16, 2024 16:35
@dweomer
Copy link
Contributor

dweomer commented Feb 16, 2024

super cute animal pic, @clemenko is a pro

@clemenko
Copy link
Contributor Author

Screenshot 2024-02-16 at 12 03 34 PM

Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs more printable emoji's imo and i would like to see the color definitions wrapped in a conditional but thems is later iterations. thanks @clemenko!

@zackbradys
Copy link
Member

zackbradys commented Feb 16, 2024

Thanks for getting this built @clemenko. Spoke with @dweomer and @amartin120 and making a few updates before merging this since we were already working on changes to install.sh

@clemenko
Copy link
Contributor Author

clemenko commented Feb 16, 2024 via email

@zackbradys
Copy link
Member

Closing per @clemenko

@zackbradys zackbradys closed this Feb 17, 2024
@zackbradys zackbradys added the wontfix This will not be worked on label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

4 participants