Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated commands #180

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Feb 16, 2024

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

  • remove deprecated commands (they've been deprecated for 5 months.)
    • hauler download (alternatively, dl) and hauler serve (NOT hauler store serve) commands

What is the current behavior?

  • commands still exist but give deprecation warnings.

What is the new behavior (if this is a feature change)?

  • deprecated commands no longer exist.

Does this PR introduce a breaking change?

  • If for some reason you're still using these commands, they'll be gone as of v1.0.0

Other information:

  • hauler download may come back in a different fashion in a later release. The previous implementation was unfinished and needs some additional thought.
  • hauler store serve "serves" more purpose than hauler serve did, which also felt unfinished.

Signed-off-by: Adam Martin <[email protected]>
@amartin120 amartin120 merged commit 46ea8b5 into hauler-dev:main Feb 17, 2024
1 check passed
@zackbradys zackbradys added this to the Hauler v1.0.0 milestone Feb 17, 2024
@amartin120 amartin120 deleted the remove-deprecated-cmds branch March 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants