Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: handle complex file names #178

Merged
merged 1 commit into from
Feb 16, 2024
Merged

bug-fix: handle complex file names #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/artifacts/file/getter/https.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ func (h Http) Name(u *url.URL) string {
return ""
}

name, _ := url.PathUnescape(u.String())
if err != nil {
return ""
}

contentType := resp.Header.Get("Content-Type")
for _, v := range strings.Split(contentType, ",") {
t, _, err := mime.ParseMediaType(v)
Expand All @@ -36,7 +41,7 @@ func (h Http) Name(u *url.URL) string {
}

// TODO: Not this
return filepath.Base(u.String())
return filepath.Base(name)
}

func (h Http) Open(ctx context.Context, u *url.URL) (io.ReadCloser, error) {
Expand Down
1 change: 1 addition & 0 deletions pkg/reference/reference.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type Reference interface {

// NewTagged will create a new docker.NamedTagged given a path-component
func NewTagged(n string, tag string) (gname.Reference, error) {
n = strings.Replace(strings.ToLower(n), "+", "-", -1)
repo, err := Parse(n)
if err != nil {
return nil, err
Expand Down
Loading