Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to add size totals and cosign artifacts to the info command #176

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Feb 14, 2024

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

  • Adds a size total to the bottom on the hauler store info table.
  • Adds any cosign bits (aka sigs, atts, and sbom) to the table / json that may make up that total if they exist.

What is the current behavior?

  • No size total or visibility into the cosign bits.

What is the new behavior (if this is a feature change)?

  • hauler store info now includes cosign bits and a size total.

image

Does this PR introduce a breaking change?

  • N/A unless you are doing stuff with the json output and weren't expecting the extra cosign artifacts.

Other information:

@amartin120
Copy link
Contributor Author

For #170

Copy link
Member

@zackbradys zackbradys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @amartin120. LGTM!!

@amartin120 amartin120 merged commit e15c8d5 into hauler-dev:main Feb 15, 2024
1 check passed
@zackbradys zackbradys added this to the Hauler v1.0.0 milestone Feb 16, 2024
@zackbradys zackbradys linked an issue Feb 16, 2024 that may be closed by this pull request
@amartin120 amartin120 deleted the info-totals branch February 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Have hauler store info show totals of the store
3 participants