image spec manifest annotations - key/platform/registry #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check below, if the PR fulfills these requirements:
What kind of change does this PR introduce?
Currently, the flags from the CLI have a global effect on any image UNLESS it has a (key/platform) specified on the individual image. Individual image key/platform takes precedence.
Moving forward, if I have
hauler.dev/key
and/orhauler.dev/platform
at the annotation level, it would work just like the CLI flag and globally apply for everything except individual images specifying otherwise. Just like above.If you just so happen to provide both an annotation AND the CLI flag for the same thing, the CLI flag wins.
As for the
hauler.dev/registry
annotation, it will apply globally unless the provided image reference already has a registry specified in its name.What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Other information: