Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hauler version display #141

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Nov 30, 2023

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

  • the goreleaser parameters to feed the build info to the version command was broken after the v0.4.0 release.

What is the current behavior?

❯ hauler version                                                                                                                                                                                                                                                                                                         
GitVersion:    devel
GitCommit:     unknown
GitTreeState:  unknown
BuildDate:     unknown
GoVersion:     go1.21.3
Compiler:      gc
Platform:      darwin/arm64

What is the new behavior (if this is a feature change)?

❯ hauler version                                                                                                                                                                                                                                                                               
GitVersion:    {correct version}
GitCommit:     756c017
GitTreeState:  clean
BuildDate:     2023-11-30T18:37:01Z
GoVersion:     go1.21.4
Compiler:      gc
Platform:      darwin/arm64

Does this PR introduce a breaking change?
Nothing

Other information:

Signed-off-by: Adam Martin <[email protected]>
@amartin120 amartin120 requested a review from dweomer November 30, 2023 18:43
@amartin120 amartin120 merged commit 2959cfc into hauler-dev:main Nov 30, 2023
1 check passed
@amartin120 amartin120 deleted the goreleaser-versioning-fix branch December 4, 2023 16:22
@amartin120 amartin120 restored the goreleaser-versioning-fix branch December 4, 2023 16:22
@amartin120 amartin120 deleted the goreleaser-versioning-fix branch February 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants