Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosign for handling image functionality. #134

Merged
merged 10 commits into from
Nov 3, 2023
Merged

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Oct 25, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Replaces default hauler image mechanics with cosign.
  • Pulls in the once separated rancherfederal/OCIL library for the remaining oci functions not handled by cosign.
  • What is the current behavior? (You can also link to an open issue here)
  • When you add an image, that's it. No other supported artifacts come with it.
  • Does not work for multi-arch images.
  • What is the new behavior (if this is a feature change)?
    When you add an image to the store, it will also attempt to include any signatures/attestations.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

cmd/hauler/cli/store/add.go Show resolved Hide resolved
pkg/artifacts/file/getter/getter_test.go Show resolved Hide resolved
pkg/artifacts/file/getter/getter_test.go Show resolved Hide resolved
pkg/consts/consts.go Show resolved Hide resolved
@dweomer dweomer merged commit 4772657 into main Nov 3, 2023
2 checks passed
@amartin120 amartin120 deleted the cosign-functionality branch November 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants