Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use uWebSockets.js as peer dependency #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtritto
Copy link

@rtritto rtritto commented Nov 26, 2024

No description provided.

@cyco130
Copy link
Member

cyco130 commented Nov 26, 2024

This is a good idea and I had the same thing in mind. But we need to add uWebSockets.js package to testbed/basic/package.json otherwise tests won't run properly.

Also you need to run pnpm install after package.json changes otherwise the lockfile will become stale. That's why the CI is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants