feat: Drop the use of the Tubular repository #34
Conversation
|
@mrtmm, If you add |
|
Ah, nice, thanks! |
mrtmm
force-pushed
the
tubular-depr
branch
2 times, most recently
from
f3e0737 to
8ed57d0
Compare
mrtmm
changed the title
mrtmm
force-pushed
the
tubular-depr
branch
2 times, most recently
from
ea158b3 to
eb00906
Compare
mrtmm
force-pushed
the
tubular-depr
branch
4 times, most recently
from
528a390 to
ea65f07
Compare
|
@mrtmm I think if you rebase your topic branch on current We can also cut one more 3.x release from the current state of |
|
Hmm, maybe it will be good to cut one more 3.x release in case someone needs the latest fixes in |
Yes, sounds good. Please go ahead and do that. |
mrtmm
force-pushed
the
tubular-depr
branch
2 times, most recently
from
1a297fe to
ca028d2
Compare
| @@ -0,0 +1,14 @@ | |||
| cool_off_days=$1 | |||
| pip install --upgrade pip && pip install -r scripts/user_retirement/requirements/base.txt --exists-action w | |||
There was a problem hiding this comment.
Just so I understand this correctly: retirement has moved into the platform repo, but the packages needed for retirement don't actually get baked into the default Tutor openedx image, meaning we have to install them every time we run the retirement scripts?
There was a problem hiding this comment.
Yes, those requirements are under the /scripts/user_retirement directory and not installed in the openedx image.
There was a problem hiding this comment.
OK, doesn't that run counter to the idea of having pre-built container images though?
(In other words: should we perhaps continue to build images, just as we did prior to Redwood?)
There was a problem hiding this comment.
Hmm, okay, I guess we can do that also yes.
There was a problem hiding this comment.
Should I go ahead and update this with building the image?
The Tubular repository has been deplrecated and the relevant scripts have been moved to the edx-platform codebase. * Drop the use of the Tubulas repository and install the retirement scripts from edx-platform.. * Add support for Tutor 18 / Open edX Redwood. Fixes: hastexo#32
The Tubular repository has been deplrecated and the relevant scripts have been moved to the edx-platform codebase.