-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Introduce Redirect
combinator
#1575
Open
nbacquey
wants to merge
7
commits into
haskell-servant:master
Choose a base branch
from
nbacquey:redirection-combinator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 28, 2022
-
New combinator to return routed path in response headers
This commit introduces a new type-level combinator, `WithRoutingHeader`. It modifies the behaviour of the following sub-API, such that all endpoint of said API return an additional routing header in their response. A routing header is a header that specifies which endpoint the incoming request was routed to. Endpoint are designated by their path, in which `Capture'` and `CaptureAll` combinators are replaced by a capture hint. This header can be used by downstream middlewares to gather information about individual endpoints, since in most cases a routing header uniquely identifies a single endpoint. Example: ```haskell type MyApi = WithRoutingHeader :> "by-id" :> Capture "id" Int :> Get '[JSON] Foo -- GET /by-id/1234 will return a response with the following header: -- ("Servant-Routed-Path", "/by-id/<id::Int>") ``` To achieve this, two refactorings were necessary: * Introduce a type `RouterEnv env` to encapsulate the `env` type (as in `Router env a`), which contains a tuple-encoded list of url pieces parsed from the incoming request. This type makes it possible to pass more information throughout the routing process, and the computation of the `Delayed env c` associated with each request. * Introduce a new kind of router, which only modifies the RouterEnv, and doesn't affect the routing process otherwise. `EnvRouter (RouterEnv env -> RouterEnv env) (Router' env a)` This new router is used when encountering the `WithRoutingHeader` combinator in an API, to notify the endpoints of the sub-API that they must produce a routing header (this behaviour is disabled by default).
Configuration menu - View commit details
-
Copy full SHA for 9be8693 - Browse repository at this point
Copy the full SHA 9be8693View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca8d44e - Browse repository at this point
Copy the full SHA ca8d44eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 809c8ce - Browse repository at this point
Copy the full SHA 809c8ceView commit details
Commits on Mar 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e0d47c8 - Browse repository at this point
Copy the full SHA e0d47c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfa854f - Browse repository at this point
Copy the full SHA bfa854fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56f639b - Browse repository at this point
Copy the full SHA 56f639bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 363d142 - Browse repository at this point
Copy the full SHA 363d142View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.