Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vault_addr section to va config info #28962

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

mister-ken
Copy link
Contributor

@mister-ken mister-ken commented Nov 19, 2024

Description

What does this PR do?

🔍 SPE-873

Adds a section to the configuration part of the Vault Agent overview.

https://developer.hashicorp.com/vault/docs/agent-and-proxy/agent#configuration

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@mister-ken mister-ken requested a review from a team as a code owner November 19, 2024 22:15
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 19, 2024
@mister-ken mister-ken self-assigned this Nov 19, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@mister-ken mister-ken requested review from a team and removed request for a team November 20, 2024 02:54
Copy link
Member

@brianshumate brianshumate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for readability

website/content/docs/agent-and-proxy/agent/index.mdx Outdated Show resolved Hide resolved
@yhyakuna yhyakuna merged commit e02d02f into main Nov 22, 2024
34 checks passed
@yhyakuna yhyakuna deleted the docs/update-agent-config branch November 22, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants