Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding logic to handle cloud-init error code 2 #28598

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

tvo0813
Copy link
Collaborator

@tvo0813 tvo0813 commented Oct 4, 2024

Description

Enos test job handling exit code 2 on ubuntu 24.04 repo sync

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@tvo0813 tvo0813 requested a review from a team as a code owner October 4, 2024 17:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 4, 2024
@tvo0813 tvo0813 added pr/no-changelog pr/no-milestone backport/ent/1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Oct 4, 2024

Build Results:
All builds succeeded! ✅

@tvo0813 tvo0813 force-pushed the enos/VAULT-31484_enos_handle_exit_2 branch 2 times, most recently from e4306ad to fccdb61 Compare October 8, 2024 16:08
@tvo0813 tvo0813 changed the title adding logic to print failures and retry if there is an cloud-init error adding logic to handle cloud-init error code 2 Oct 8, 2024
@tvo0813 tvo0813 force-pushed the enos/VAULT-31484_enos_handle_exit_2 branch from 0cbc2cb to c93b249 Compare November 20, 2024 19:54
@ryancragun ryancragun added the backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent label Nov 22, 2024
@tvo0813 tvo0813 merged commit d5a7ac2 into main Nov 22, 2024
99 checks passed
@tvo0813 tvo0813 deleted the enos/VAULT-31484_enos_handle_exit_2 branch November 22, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants