CI and build updates #324
Merged
CI and build updates #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go get golang.org/x/crypto@latest golang.org/x/net@latest go mod tidy
go get github.com/golangci/golangci-lint@latest \ github.com/hashicorp/copywrite@latest \ mvdan.cc/gofumpt@latest go mod tidy
go get golang.org/x/crypto@latest golang.org/x/net@latest
benashz
approved these changes
Jan 7, 2025
| @@ -35,7 +35,7 @@ jobs: | |||
| run: make bootstrap | |||
|
|
|||
| - name: Lint | |||
| run: make lint GOLANGCI_LINT_FORMAT=github-actions | |||
| run: make lint GOLANGCI_LINT_FORMAT=colored-line-number | |||
There was a problem hiding this comment.
I think it still works with a warning, but the "github-actions" format was deprecated in v1.59.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update golang to 1.23.4,
golang/xpackages, CI tools, and the image in the deployment yaml.The go update will help with #331, since [email protected] needs >= go 1.22.7.