Privileges datasource #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megan07
approved these changes
Jun 16, 2021
| @@ -71,6 +72,14 @@ resource "googleworkspace_group_settings" "sales-settings" { | |||
| - **id** (String) The ID of this resource. | |||
| - **name** (String) Name of the group, which has a maximum size of 75 characters. | |||
|
|
|||
| <a id="nestedblock--timeouts"></a> | |||
| ### Nested Schema for `timeouts` | |||
| duplicates[id] = true | ||
| } | ||
| if len(priv.ChildPrivileges) > 0 { | ||
| result = append(result, flattenAndPrunePrivileges(priv.ChildPrivileges, duplicates)...) |
There was a problem hiding this comment.
Have you found that there would be a parent duplicated in a child? I'm wondering if we need to be concerned about passing duplicates around?
There was a problem hiding this comment.
I wasn't sure, but this solution should be robust
docs/data-sources/privileges.md
Outdated
| ### Read-Only | ||
|
|
||
| - **etag** (String) ETag of the resource. | ||
| - **items** (List of Object) A list of Privilege resources. (see [below for nested schema](#nestedatt--items)) |
There was a problem hiding this comment.
do we want to mention somewhere that this will be a flattened list?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datasource that exports list of privileges. See examples for how to use terraform
foras well asdynamicto filter the list, and generateprivilegesblocks in role resources.This PR also enables
ORG_UNITscopedrole_assignment, however the practitioner must ensure onlyis_org_unit_scopableprivileges are passed along.Odd discovery, the Google API returns
org_unitids with aid:prefix, somehow this isn't an issue for the org unit resource/datasource itself, however I had to strip that prefix when passing it therole_assignmentresource. Perhaps theorg_unitresource should strip that itself? It feels like a mistake on the API end to have that prefix.Closes #72