Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the numConsistent to 2 #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

c4po
Copy link

@c4po c4po commented Oct 7, 2024

Change numConsistent from 4 to 2 in eventual consistency check

Description

This PR modifies the numConsistent constant in the eventual consistency check mechanism, reducing it from 4 to 2. This change aims to optimize the consistency check process by requiring fewer consistent reads before considering a resource state as consistent.

Changes

  • Updated numConsistent constant in internal/provider/eventual_consistency.go from 4 to 2
  • Modified test cases in internal/provider/eventual_consistency_test.go to align with the new numConsistent value

Motivation and Context

@c4po c4po requested a review from a team as a code owner October 7, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant