chore: change the numConsistent to 2 #488
Open
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change numConsistent from 4 to 2 in eventual consistency check
Description
This PR modifies the
numConsistent
constant in the eventual consistency check mechanism, reducing it from 4 to 2. This change aims to optimize the consistency check process by requiring fewer consistent reads before considering a resource state as consistent.Changes
numConsistent
constant ininternal/provider/eventual_consistency.go
from 4 to 2internal/provider/eventual_consistency_test.go
to align with the newnumConsistent
valueMotivation and Context
googleworkspace_group_member
resource #475numConsistent
may have been overly conservative, potentially leading to timeouts in resource operations. By reducing this to 2, we aim to strike a better balance between ensuring consistency and avoiding unnecessary timeouts in resource provisioning