Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests checking the import of user and group resources by email #324

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Jun 6, 2022

Description

Added tests that check the ability to import users and groups using their emails and assert that the stored id in state is the underlying ID within the API instead of the email.

This is to ensure there aren't any downsides to this change in the documentation : #278

@SarahFrench SarahFrench requested a review from megan07 June 7, 2022 10:45
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@SarahFrench SarahFrench merged commit 52e1ea9 into main Jun 8, 2022
@SarahFrench SarahFrench deleted the add-acctest-import-by-email branch June 8, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants