Resource: Gmail Send As Aliases #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
changed the title
megan07
reviewed
Jul 27, 2021
megan07
approved these changes
Jul 27, 2021
| @@ -20,7 +20,7 @@ func TestAccDataSourcePrivileges_basic(t *testing.T) { | |||
| Config: testAccDataSourcePrivileges(), | |||
| Check: resource.ComposeTestCheckFunc( | |||
| resource.TestCheckResourceAttrSet("data.googleworkspace_privileges.test", "etag"), | |||
| resource.TestCheckResourceAttr("data.googleworkspace_privileges.test", "items.#", "104"), | |||
| resource.TestCheckResourceAttr("data.googleworkspace_privileges.test", "items.#", "107"), | |||
There was a problem hiding this comment.
is this something we'll need to constantly be updating?
There was a problem hiding this comment.
probably... I don't really care about getting it exact, maybe we write a custom check that just ensures its > 0?
|
|
||
| log.Printf("[DEBUG] Getting Gmail Send As Alias %q", d.Id()) | ||
|
|
||
| sendAs, err := sendAsAliasService.Get("me", d.Get("send_as_email").(string)).Do() |
There was a problem hiding this comment.
Is "me" just a placeholder here?
There was a problem hiding this comment.
No, since we impersonated the user getting the changes, you can put "me" as a special "userId".. Ideally this would just work without the impersonation workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to create send-as aliases, both internal and external to google. However as stated in #117 testing external aliases was not possible due to SMTP relay requirement.
primary_emailwas chosen as the config attribute for what this API refers to asuserIdthis was chosen to maintain consistency across provider resources.Closes #117