Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning on s3 outposts #40759

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AnanyaDevGo
Copy link

@AnanyaDevGo AnanyaDevGo commented Jan 3, 2025

Description
This PR introduces a new resource, aws_s3control_bucket_versioning, to support enabling versioning for S3 Outposts buckets. The existing aws_s3_bucket_versioning resource is not modified and remains dedicated to regular S3 buckets.

Context
The issue, #33119, highlights that the aws_s3_bucket_versioning resource cannot handle S3 Outposts buckets due to:

API Differences: Outposts require s3control.PutBucketVersioning instead of s3.PutBucketVersioning.
Validation Differences: Outposts use ARNs (arn:aws:s3-outposts) instead of bucket names.
Versioning Status Support: Outposts only support Enabled and Suspended statuses, not Disabled.

Closes #33119.

@AnanyaDevGo AnanyaDevGo requested a review from a team as a code owner January 3, 2025 06:57
Copy link

github-actions bot commented Jan 3, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/s3control Issues and PRs that pertain to the s3control service. examples Introduces or discusses updates to examples. needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @AnanyaDevGo 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@AnanyaDevGo AnanyaDevGo closed this Jan 3, 2025
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2025
@AnanyaDevGo AnanyaDevGo reopened this Jan 3, 2025
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Introduces or discusses updates to examples. new-resource Introduces a new resource. service/s3control Issues and PRs that pertain to the s3control service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Resource aws_s3_bucket_versioning can't be created for s3 outpost bucket
2 participants