Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to the aws_ec2_instance_type data source #40717

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bakeemawaytoys
Copy link
Contributor

Description

Added the following attributes to the aws_ec2_instance_type data source to bring it up-to-date with the EC2 API. I tried to follow the data source's established conventions with respect to nullability, naming, and flattening attributes that are nested in the AWS API. One thing I'm not clear on is which type to use for attributes that are collections of strings. I went with sets instead of lists because ordering doesn't make sense nor is it explicitly guaranteed by the AWS API. Existing attributes tended be lists. I can change them to lists if consistency is more important.

As I was updating the documentation, I adjusted some of the descriptions of existing attributes to clarify their data types and/or their expected values. My intent is to reduce the need to cross-reference the data source's documentation with the AWS API documentation in order to understand the attribute values.

  • bandwidth_weightings
  • boot_modes
  • default_network_card_index
  • efa_maximum_interfaces
  • inference_accelerators.#.memory_size
  • media_accelerators.#.count
  • media_accelerators.#.manufacturer
  • media_accelerators.#.memory_size
  • media_accelerators.#.name
  • network_cards.#.baseline_bandwidth
  • network_cards.#.index
  • network_cards.#.maximum_interfaces
  • network_cards.#.performance
  • network_cards.#.peak_bandwidth
  • neuron_devices.#.core_count
  • neuron_devices.#.count
  • neuron_devices.#.memory_size
  • neuron_devices.#.name
  • neuron_devices.#.version
  • nitro_enclaves_support
  • nitro_tpm_support
  • nitro_tpm_supported_versions
  • phc_support
  • srd_supported
  • supported_cpu_features
  • total_inference_memory
  • total_media_memory
  • total_neuron_device_memory

Relations

Closes #35640

References

AWS CLI documentation for the describe-instance-type command
AWS EC2 API documentation for the DescribeInstanceTypes action

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. labels Dec 28, 2024
@bakeemawaytoys bakeemawaytoys force-pushed the f-aws_ec2_instance_type-add-missing-attributes branch 3 times, most recently from bde9584 to 5ce64a6 Compare December 28, 2024 23:29
Added the following attributes to the `aws_ec2_instance_type` data source to bring it up-to-date with the EC2 API.

* `bandwidth_weightings`
* `boot_modes`
* `default_network_card_index`
* `efa_maximum_interfaces`
* `inference_accelerators.#.memory_size`
* `media_accelerators.#.count`
* `media_accelerators.#.manufacturer`
* `media_accelerators.#.memory_size`
* `media_accelerators.#.name`
* `network_cards.#.baseline_bandwidth`
* `network_cards.#.index`
* `network_cards.#.maximum_interfaces`
* `network_cards.#.performance`
* `network_cards.#.peak_bandwidth`
* `neuron_devices.#.core_count`
* `neuron_devices.#.count`
* `neuron_devices.#.memory_size`
* `neuron_devices.#.name`
* `neuron_devices.#.version`
* `nitro_enclaves_support`
* `nitro_tpm_support`
* `nitro_tpm_supported_versions`
* `phc_support`
* `srd_supported`
* `supported_cpu_features`
* `total_inference_memory`
* `total_media_memory`
* `total_neuron_device_memory`
@bakeemawaytoys bakeemawaytoys force-pushed the f-aws_ec2_instance_type-add-missing-attributes branch from 5ce64a6 to 60daab4 Compare December 29, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_ec2_instance_type does not have attribues for NetworkInfo.NetworkCards value
1 participant