Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new data sources to aws_bedrockagent_data_source #40711

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hjoshi123
Copy link
Contributor

Description

This PR introduces new data source configurations like confluence, sharePoint, salesforce to aws_bedrockagent_data_source resource which was introduced recently Bedrock API. Schema and data models have been updated for the same.

Relations

Closes #40577

References

https://docs.aws.amazon.com/bedrock/latest/APIReference/API_agent_DataSourceConfiguration.html#bedrock-Type-agent_DataSourceConfiguration-webConfiguration

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@hjoshi123 hjoshi123 requested a review from a team as a code owner December 28, 2024 02:18
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/bedrockagent Issues and PRs that pertain to the bedrockagent service. needs-triage Waiting for first response or review from a maintainer. labels Dec 28, 2024
@hjoshi123
Copy link
Contributor Author

Need help in writing acceptance tests since I am not sure what the values of the data configurations should be. It would be nice if someone could assist me on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for first response or review from a maintainer. service/bedrockagent Issues and PRs that pertain to the bedrockagent service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for other data sources in aws_bedrockagent_data_source
1 participant