r/aws_instance: Set public_dns and public_ip as newly Computed if instance is stopped/started

[ewbankkit]

Description

Set public_dns and public_ip as newly Computed if an aws_instance update would stop then start the instance as this may result in an IP address change -- see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-instance-addressing.html#concepts-public-addresses.

Relations

Closes #6781.
Closes #10720.
Closes #20651.
Closes #24690.
Closes #33726.

Output from Acceptance Testing

% make testacc TESTARGS='-run=^TestAccEC2Instance_changeInstanceType' PKG=ec2  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=^TestAccEC2Instance_changeInstanceType -timeout 360m
2024/12/27 14:05:09 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2Instance_changeInstanceType
=== PAUSE TestAccEC2Instance_changeInstanceType
=== RUN   TestAccEC2Instance_changeInstanceTypeReplace
=== PAUSE TestAccEC2Instance_changeInstanceTypeReplace
=== RUN   TestAccEC2Instance_changeInstanceTypeAndUserData
=== PAUSE TestAccEC2Instance_changeInstanceTypeAndUserData
=== RUN   TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== PAUSE TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== CONT  TestAccEC2Instance_changeInstanceType
=== CONT  TestAccEC2Instance_changeInstanceTypeAndUserData
=== CONT  TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== CONT  TestAccEC2Instance_changeInstanceTypeReplace
--- PASS: TestAccEC2Instance_changeInstanceTypeReplace (257.49s)
--- PASS: TestAccEC2Instance_changeInstanceType (304.14s)
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserDataBase64 (494.12s)
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserData (555.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	561.513s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[nam054]

LGTM 🚀

> make testacc TESTARGS='-run=^TestAccEC2Instance_changeInstanceType' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=^TestAccEC2Instance_changeInstanceType -timeout 360m
2024/12/30 11:57:40 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2Instance_changeInstanceType
=== PAUSE TestAccEC2Instance_changeInstanceType
=== RUN   TestAccEC2Instance_changeInstanceTypeReplace
=== PAUSE TestAccEC2Instance_changeInstanceTypeReplace
=== RUN   TestAccEC2Instance_changeInstanceTypeAndUserData
=== PAUSE TestAccEC2Instance_changeInstanceTypeAndUserData
=== RUN   TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== PAUSE TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== CONT  TestAccEC2Instance_changeInstanceType
=== CONT  TestAccEC2Instance_changeInstanceTypeAndUserData
=== CONT  TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== CONT  TestAccEC2Instance_changeInstanceTypeReplace
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserDataBase64 (463.68s)
--- PASS: TestAccEC2Instance_changeInstanceType (548.22s)
--- PASS: TestAccEC2Instance_changeInstanceTypeReplace (606.09s)
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserData (701.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        708.698s