-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_ses_identity_notification_topic: Do not fail when deleting not existing resource #40684
Merged
ewbankkit
merged 5 commits into
hashicorp:main
from
kamilturek:b-aws-ses-identity-notification-topic-delete-invalid
Dec 23, 2024
Merged
r/aws_ses_identity_notification_topic: Do not fail when deleting not existing resource #40684
ewbankkit
merged 5 commits into
hashicorp:main
from
kamilturek:b-aws-ses-identity-notification-topic-delete-invalid
Dec 23, 2024
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/ses
Issues and PRs that pertain to the ses service.
needs-triage
Waiting for first response or review from a maintainer.
external-maintainer
Contribution from a trusted external contributor.
labels
Dec 23, 2024
ewbankkit
added
bug
Addresses a defect in current functionality.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Dec 23, 2024
github-actions
bot
added
the
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
label
Dec 23, 2024
ewbankkit
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSESIdentityNotificationTopic_' PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ses/... -v -count 1 -parallel 20 -run=TestAccSESIdentityNotificationTopic_ -timeout 360m
2024/12/23 15:32:46 Initializing Terraform AWS Provider...
=== RUN TestAccSESIdentityNotificationTopic_basic
=== PAUSE TestAccSESIdentityNotificationTopic_basic
=== RUN TestAccSESIdentityNotificationTopic_Disappears_domainIdentity
=== PAUSE TestAccSESIdentityNotificationTopic_Disappears_domainIdentity
=== CONT TestAccSESIdentityNotificationTopic_basic
=== CONT TestAccSESIdentityNotificationTopic_Disappears_domainIdentity
--- PASS: TestAccSESIdentityNotificationTopic_Disappears_domainIdentity (11.62s)
--- PASS: TestAccSESIdentityNotificationTopic_basic (30.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ses 36.168s
nam054
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@kamilturek Thanks for the contribution 🎉 👏. |
kamilturek
deleted the
b-aws-ses-identity-notification-topic-delete-invalid
branch
December 23, 2024 22:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Addresses a defect in current functionality.
external-maintainer
Contribution from a trusted external contributor.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/ses
Issues and PRs that pertain to the ses service.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
aws_ses_identity_notification_topic
to prevent failing when deleting not existing resource.Relations
Closes #36275.
References
https://docs.aws.amazon.com/ses/latest/APIReference/API_SetIdentityNotificationTopic.html
Output from Acceptance Testing