Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ses_identity_notification_topic: Do not fail when deleting not existing resource #40684

Conversation

kamilturek
Copy link
Collaborator

Description

This PR fixes the aws_ses_identity_notification_topic to prevent failing when deleting not existing resource.

Relations

Closes #36275.

References

https://docs.aws.amazon.com/ses/latest/APIReference/API_SetIdentityNotificationTopic.html

Output from Acceptance Testing

% make testacc PKG=ses ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccSESIdentityNotificationTopic_basic"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ses/... -v -count 1 -parallel 1  -run=TestAccSESIdentityNotificationTopic_basic -timeout 360m
2024/12/23 20:20:11 Initializing Terraform AWS Provider...
=== RUN   TestAccSESIdentityNotificationTopic_basic
=== PAUSE TestAccSESIdentityNotificationTopic_basic
=== CONT  TestAccSESIdentityNotificationTopic_basic
--- PASS: TestAccSESIdentityNotificationTopic_basic (45.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        50.610s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ses Issues and PRs that pertain to the ses service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Dec 23, 2024
@kamilturek kamilturek marked this pull request as ready for review December 23, 2024 19:48
@kamilturek kamilturek requested a review from a team as a code owner December 23, 2024 19:48
@ewbankkit ewbankkit self-assigned this Dec 23, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 23, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 23, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESIdentityNotificationTopic_' PKG=ses 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ses/... -v -count 1 -parallel 20  -run=TestAccSESIdentityNotificationTopic_ -timeout 360m
2024/12/23 15:32:46 Initializing Terraform AWS Provider...
=== RUN   TestAccSESIdentityNotificationTopic_basic
=== PAUSE TestAccSESIdentityNotificationTopic_basic
=== RUN   TestAccSESIdentityNotificationTopic_Disappears_domainIdentity
=== PAUSE TestAccSESIdentityNotificationTopic_Disappears_domainIdentity
=== CONT  TestAccSESIdentityNotificationTopic_basic
=== CONT  TestAccSESIdentityNotificationTopic_Disappears_domainIdentity
--- PASS: TestAccSESIdentityNotificationTopic_Disappears_domainIdentity (11.62s)
--- PASS: TestAccSESIdentityNotificationTopic_basic (30.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	36.168s

Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9524f4f into hashicorp:main Dec 23, 2024
35 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 23, 2024
@kamilturek kamilturek deleted the b-aws-ses-identity-notification-topic-delete-invalid branch December 23, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_ses_identity_notification_topic -- Do not fail when deleting not existing resource
3 participants